馃 Update for Unicode 14 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ticky
commented
Sep 29, 2021
|
Confirmed that this works in-situ in buildkite/emojis |
Unicode 14 is here, and with it are some breaking changes in `emoji-regex`, which mean we need to change how we generate our own stuff. To accomplish this, we're moving to the slightly-more-upstream package, `emoji-test-regex-pattern`, and using its `java` regex variation. This also means removing all but the one regular expression. We previously marked `Emoji` as deprecated, but the plan now is to mark `Text` as deprecated also.
ticky
force-pushed
the
update-for-unicode-14
branch
from
b1bfc4c
to
c98adff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unicode 14 is here, and with it are some breaking changes in
emoji-regex, which mean we need to change how we generate our own stuff.To accomplish this, we're moving to the slightly-more-upstream package,
emoji-test-regex-pattern, and using itsjavaregex variation.This also means removing all but the one regular expression.